Re: [PATCH 1/2] HID: logitech-dj: add support for the new lightspeed receiver iteration
From: Jiri Kosina
Date: Fri Feb 05 2021 - 18:52:40 EST
On Sat, 23 Jan 2021, Filipe Laíns wrote:
> From: Filipe Laíns <lains@xxxxxxxxxx>
>
> Tested with the G Pro X Superlight. libratbag sees the device, as
> expected, and input events are passing trough.
>
> https://github.com/libratbag/libratbag/pull/1122
>
> The receiver has a quirk where the moused interface doesn't have a
> report ID, I am not sure why, perhaps they forgot. All other interfaces
> have report IDs so I am left scratching my head.
> Since this driver doesn't have a quirk system, I simply implemented it
> as a different receiver type, which is true, it just wouldn't be the
> prefered approach :P
Benjamin, do you have any other idea how to accomplish this without this
kind of spaghetti-style conditions?
If not, I am tempted to apply the patch as is.
Thanks,
--
Jiri Kosina
SUSE Labs