Re: [RFC v1 13/26] x86/tdx: Handle MWAIT, MONITOR and WBINVD

[Andy Lutomirski]

On Fri, Feb 5, 2021 at 3:54 PM Kuppuswamy, Sathyanarayanan
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
>
> Hi Andy,
>
> On 2/5/21 3:43 PM, Andy Lutomirski wrote:
> > MWAIT turning into NOP is no good.  How about suppressing
> > X86_FEATURE_MWAIT instead?
> Yes, we can suppress it in tdx_early_init().
>
>   + setup_clear_cpu_cap(X86_FEATURE_MWAIT);
>
> But do you want to leave the MWAIT #VE handler as it as
> (just in case)?
>

I would suggest decoding the error, printing a useful message, and
oopsing or at least warning.

>
> --
> Sathyanarayanan Kuppuswamy
> Linux Kernel Developer