Re: [PATCH] drm: bridge: convert sysfs sprintf/snprintf family to sysfs_emit

From: Robert Foss
Date: Mon Feb 08 2021 - 05:39:55 EST


Hey Jiapeng,

Thanks for the patch. Feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>

On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong
<jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use
> scnprintf or sprintf.
>
> Reported-by: Abaci Robot<abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index fee2795..3cac16d 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -855,7 +855,7 @@ static ssize_t lt9611uxc_firmware_show(struct device *dev, struct device_attribu
> {
> struct lt9611uxc *lt9611uxc = dev_get_drvdata(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%02x\n", lt9611uxc->fw_version);
> + return sysfs_emit(buf, "%02x\n", lt9611uxc->fw_version);
> }
>
> static DEVICE_ATTR_RW(lt9611uxc_firmware);
> --
> 1.8.3.1
>