Re: [PATCH] kbuild: simplify access to the kernel's version

From: Sasha Levin
Date: Mon Feb 08 2021 - 15:03:01 EST


On Mon, Feb 08, 2021 at 05:50:07PM +0000, Christoph Hellwig wrote:
On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote:
+ (u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL),
+ (u16)(LINUX_VERSION_SUBLEVEL));

No need for the casts and braces.

Otherwise this looks good, but please also kill off KERNEL_VERSION
and LINUX_KERNEL_VERSION entirely while you're at it.

I don't think there are in-tree users left?

We can't remove it completely because userspace is still using it, so if
we drop those userspace will be sad.

--
Thanks,
Sasha