Re: [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

[Stephen Boyd]

Quoting Jernej Skrabec (2021-02-08 04:17:48)
> CLK_SET_RATE_PARENT flag is checked on parent clock instead of current
> one. Fix that.
> 
> Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when allowed")
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
> Tested-by: Andre Heider <a.heider@xxxxxxxxx>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
> ---
>  drivers/clk/sunxi-ng/ccu_mp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu_mp.c b/drivers/clk/sunxi-ng/ccu_mp.c
> index fa4ecb915590..5f40be6d2dfd 100644
> --- a/drivers/clk/sunxi-ng/ccu_mp.c
> +++ b/drivers/clk/sunxi-ng/ccu_mp.c
> @@ -108,7 +108,7 @@ static unsigned long ccu_mp_round_rate(struct ccu_mux_internal *mux,
>         max_m = cmp->m.max ?: 1 << cmp->m.width;
>         max_p = cmp->p.max ?: 1 << ((1 << cmp->p.width) - 1);
>  
> -       if (!(clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT)) {
> +       if (!(clk_hw_get_flags(&cmp->common.hw) & CLK_SET_RATE_PARENT)) {

This is also clk_hw_can_set_rate_parent()

>                 ccu_mp_find_best(*parent_rate, rate, max_m, max_p, &m, &p);
>                 rate = *parent_rate / p / m;
>         } else {