Re: [PATCH] i2c: mv64xxx: Fix check for missing clock
From: Jakub Kicinski
Date: Mon Feb 08 2021 - 16:43:15 EST
On Mon, 8 Feb 2021 00:31:34 -0600 Samuel Holland wrote:
> On 2/8/21 12:28 AM, Samuel Holland wrote:
> > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> > pointers to optional clocks were replaced by NULL to simplify the resume
> > callback implementation. However, that commit missed that the IS_ERR
> > check in mv64xxx_of_config should be replaced with a NULL check. As a
> > result, the check always passes, even for an invalid device tree.
>
> Sorry, please ignore this unrelated patch. I accidentally copied it to
> the wrong directory before sending this series.
Unfortunately patchwork decided to take this patch in instead of the
real 1/5 patch. Please make a clean repost even if there are no review
comments to address.