Re: [PATCH] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match

From: Nathan Chancellor
Date: Mon Feb 08 2021 - 23:32:30 EST


On Thu, Dec 31, 2020 at 06:42:23PM +0100, Alexandre Belloni wrote:
> On Mon, 21 Dec 2020 19:59:31 -0700, Nathan Chancellor wrote:
> > Clang warns:
> >
> > ../drivers/i3c/master/mipi-i3c-hci/core.c:780:21: warning: attribute
> > declaration must precede definition [-Wignored-attributes]
> > static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> > ^
> > ../include/linux/compiler_attributes.h:267:56: note: expanded from macro
> > '__maybe_unused'
> > #define __maybe_unused __attribute__((__unused__))
> > ^
> > ../include/linux/mod_devicetable.h:262:8: note: previous definition is
> > here
> > struct of_device_id {
> > ^
> > 1 warning generated.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match
> commit: 291b5c9870fc546376d69cf792b7885cd0c9c1b3
>
> Best regards,
> --
> Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
>

Hi Alexandre,

I see as of v5.11-rc7 that this is still an issue even though it has
been applied to the fixes branch. Is it possible for this to make it in
to 5.11 final?

Cheers,
Nathan