Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop

From: Ioana Ciornei
Date: Tue Feb 09 2021 - 04:22:07 EST


On Mon, Feb 08, 2021 at 09:58:10PM +0300, Dan Carpenter wrote:
> On Mon, Feb 08, 2021 at 07:09:47PM +0200, Ioana Ciornei wrote:
> > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > The "desc" pointer can't possibly be NULL here. If we can't find the
> > correct "desc" then tt points to the last element of the
> > fsl_mc_accepted_cmds[] array. Fix this by testing if
> > "i == FSL_MC_NUM_ACCEPTED_CMDS" instead.
> >
> > Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Generally the tags are expected to go in chronological order:
>
> Fixes: commit
> Signed-off-by: Author
> Acked-by: Whoever
> Signed-off-by: Maintainer
>

Thanks! I didn't know that.

Ioana