Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue.

[Greg KH]

On Tue, Feb 09, 2021 at 06:36:19PM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
> 
> Signed-off-by: Mukul Mehar <mukulmehar02@xxxxxxxxx>
> ---
>  drivers/staging/most/sound/sound.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
> index 3a1a59058042..4dd1bf95d1ce 100644
> --- a/drivers/staging/most/sound/sound.c
> +++ b/drivers/staging/most/sound/sound.c
> @@ -228,12 +228,12 @@ static int playback_thread(void *data)
>  		struct mbo *mbo = NULL;
>  		bool period_elapsed = false;
>  
> -		wait_event_interruptible(
> -			channel->playback_waitq,
> -			kthread_should_stop() ||
> -			(channel->is_stream_running &&
> -			 (mbo = most_get_mbo(channel->iface, channel->id,
> -					     &comp))));
> +		wait_event_interruptible(channel->playback_waitq,
> +					 kthread_should_stop() ||
> +					 (channel->is_stream_running &&
> +					 (mbo = most_get_mbo(channel->iface,
> +					 channel->id,
> +					 &comp))));

This line is horrid, you can indent it further (line up the
most_get_mbo() parameters at the least.

Also you lost the extra indentation of the "(mbo " portion, can you make
sure that is there too?

thanks,

greg k-h