Re: [PATCH 1/2] rcuscale: add kfree_rcu() single-argument scale test

From: Uladzislau Rezki
Date: Tue Feb 09 2021 - 19:18:31 EST


On Thu, Feb 04, 2021 at 01:46:48PM -0800, Paul E. McKenney wrote:
> On Fri, Jan 29, 2021 at 09:05:04PM +0100, Uladzislau Rezki (Sony) wrote:
> > To stress and test a single argument of kfree_rcu() call, we
> > should to have a special coverage for it. We used to have it
> > in the test-suite related to vmalloc stressing. The reason is
> > the rcuscale is a correct place for RCU related things.
> >
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
>
> This is a great addition, but it would be even better if there was
> a way to say "test both in one run". One way to do this is to have
> torture_param() variables for both kfree_rcu_test_single and (say)
> kfree_rcu_test_double, both bool and both initialized to false. If both
> have the same value (false or true) both are tested, otherwise only
> the one with value true is tested. The value of this is that it allows
> testing of both options with one test.
>
Make sense to me :)