Re: [PATCH v7 0/6] tracing: More synthetic event error fixes

[Steven Rostedt]

On Mon,  1 Feb 2021 13:48:10 -0600
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> Hi,
> 
> This is v7 of the synthetic event error fix patchset.  This version
> addresses the comments from v6:
> 
>   - moved check_command() from '[PATCH v6 3/6] tracing: Update synth
>     command errors' to '[PATCH v6 2/6] tracing: Rework synthetic event
>     command parsing'.
> 
>   - in __create_synth_event(), moved mutex_lock(&event_mutex) after
>     is_good_name() check and changed related error handling.
> 
>   - simplified check_command() a bit by calling argv_free() sooner as
>     suggested by Steve.
> 
>   - added Steve's comment about check_field_version() into that
>     function and added additional comments to the caller.
> 

After applying these, the following test fails:

 test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc

It appears that:

  echo 'myevent char str[];; int v' > synthetic_events

doesn't error after these changes.

-- Steve