Re: [PATCH net-next 7/9] net: phy: icplus: select page before writing control register

From: Andrew Lunn
Date: Tue Feb 09 2021 - 21:32:17 EST


On Tue, Feb 09, 2021 at 05:40:49PM +0100, Michael Walle wrote:
> Registers >= 16 are paged. Be sure to set the page. It seems this was
> working for now, because the default is correct for the registers used
> in the driver at the moment. But this will also assume, nobody will
> change the page select register before linux is started. The page select
> register is _not_ reset with a soft reset of the PHY.
>
> Add read_page()/write_page() support for the IP101G and use it
> accordingly.
>
> Signed-off-by: Michael Walle <michael@xxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew