Re: [PATCH v2 06/28] locking/rwlocks: Add contention detection for rwlocks

From: Guenter Roeck
Date: Wed Feb 10 2021 - 01:06:35 EST


On 2/9/21 4:27 PM, Waiman Long wrote:
[ ... ]

>
> It is because in arch/mips/include/asm/spinlock.h, asm/qrwlock.h is included before asm/qspinlock.h. The compilation error should be gone if the asm/qrwlock.h is removed or moved after asm/qspinlock.h.
>
> I did a x86 build and there was no compilation issue.
>
I can not really comment on what exactly is wrong - I don't know the code well
enough to do that - but I don't think this is a valid argument.

Anyway, it seems like mips is the only architecture affected by the problem.
I am not entirely sure, though - linux-next is too broken for that.

Thanks,
Guenter