Re: [PATCH] sign-file: add openssl engine support

[David Howells]

Yang Song <songyang@xxxxxxxxxxxxxxxxx> wrote:

> +		"Usage: scripts/sign-file [-edp] [<openssl engine>] <hash algo> <key> <x509> <module> [<dest>]\n");

Do you mean:

		"Usage: scripts/sign-file [-dp] [-e <openssl engine>] <hash algo> <key> <x509> <module> [<dest>]\n");

> +		opt = getopt(argc, argv, "sedpk");

"se:dpk"?

> +		if (use_engine) {
> +			ossl_engine = argv[0];

use_engine ought to be a redundant variable.

David