Re: [PATCH] mm/hugetlb: use some helper functions to cleanup code

From: David Hildenbrand
Date: Wed Feb 10 2021 - 03:41:51 EST


On 10.02.21 07:53, Miaohe Lin wrote:
We could use pages_per_huge_page to get the number of pages per hugepage,
use get_hstate_idx to calculate hstate index, and use hstate_is_gigantic
to check if a hstate is gigantic to make code more succinct.


Another suggestion, please collect and group your cleanups for a subsystem and send them in a single cleanup patch series where possible. Again, makes life easier for reviewers and maintainers.

Thanks!


--
Thanks,

David / dhildenb