Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc
From: Dan Carpenter
Date: Wed Feb 10 2021 - 04:14:13 EST
On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote:
> On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > > @@ -789,7 +759,7 @@ static void phy_PostSetBwMode8723B(struct adapter *Adapter)
> > >
> > > PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x0);
> > >
> > > -/* PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */
> > > + /*PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */
> >
> > This format is wrong. Anyway, just delete the commented out code.
> >
> > regards,
> > dan carpenter
> >
>
> how can i delete that, i have no idea what this driver does
> i'm just fixing coding style issues for eudyptula challenge.
> i dont think its a good idea to delete the code without knowing its
> purpose even though its commented out
Commented code obviously doesn't do anything at all?
regards,
dan carpenter