RE: [EXT] Re: [PATCH v11 net-next 15/15] net: mvpp2: add TX FC firmware check

[Stefan Chulski]

> >  	if (priv->global_tx_fc && priv->hw_version != MVPP21) {
> > -		val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
> > -		val |= FLOW_CONTROL_ENABLE_BIT;
> > -		mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
> > +		err = mvpp2_enable_global_fc(priv);
> > +		if (err) {
> > +			dev_warn(&pdev->dev, "CM3 firmware not running,
> version should be higher than 18.09 ");
> > +			dev_warn(&pdev->dev, "and chip revision B0\n");
> > +			dev_warn(&pdev->dev, "Flow control not
> supported\n");
> 
> I would much rather this was:
> 
> 			dev_warn(&pdev->dev, "Minimum of CM3 firmware
> 18.09 and chip revision B0 required for flow control\n");
> 
> rather than trying to split it across several kernel messages.

I would repots v12 with this change soon.

Thanks,
Stefan.