Re: [PATCH] perf stat: Use nftw() instead of ftw()
From: Namhyung Kim
Date: Wed Feb 10 2021 - 04:18:42 EST
Hi,
On Tue, Feb 9, 2021 at 4:29 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> Em Mon, Feb 08, 2021 at 06:11:57PM +0000, Paul Cercueil escreveu:
> > ftw() has been obsolete for about 12 years now.
> >
> > Fixes: bb1c15b60b98 ("perf stat: Support regex pattern in --for-each-cgroup")
> > CC: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> > ---
> >
> > Notes:
> > NOTE: Not runtime-tested, I have no idea what I need to do in perf
> > to test this. But at least it compiles now with my uClibc-based
> > toolchain.
>
> Seems safe from reading the nftw() man page, the only typeflag that this
> code is using is FTW_D and that is present in both ftw() and nftw().
>
> Applying,
Didn't notice it was obsolete.
Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
Thanks,
Namhyung