Re: [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service()

[Paolo Valente]

> Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@xxxxxxxxx> ha scritto:
> 
> From: Chunguang Xu <brookxu@xxxxxxxxxxx>
> 
> The if statement at the end of the function is obviously useless,
> maybe we can delete it.
> 

Thanks for spotting this mistake.

Acked-by: Paolo Valente <paolo.valente@xxxxxxxxxx>

> Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
> ---
> block/bfq-wf2q.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> index 26776bd..070e34a 100644
> --- a/block/bfq-wf2q.c
> +++ b/block/bfq-wf2q.c
> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
> 
> 	sd->next_in_service = next_in_service;
> 
> -	if (!next_in_service)
> -		return parent_sched_may_change;
> -
> 	return parent_sched_may_change;
> }
> 
> -- 
> 1.8.3.1
>