Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference error

From: Kishon Vijay Abraham I
Date: Wed Feb 10 2021 - 06:38:10 EST


Hi Peter,

On 10/02/21 3:33 pm, Péter Ujfalusi wrote:
> Hi Kishon,
>
> On 2/9/21 2:02 PM, Kishon Vijay Abraham I wrote:
>> bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow is
>> already allocated by checking if it has a NON NULL value. For the
>> error cases, bchan/rchan/tchan/rflow will have error value
>> and bcdma_get_*() and udma_get_*() considers this as already allocated
>> (PASS) since the error values are NON NULL. This results in
>> NULL pointer dereference error while de-referencing
>> bchan/rchan/tchan/rflow.
>>
>> Reset the value of bchan/rchan/tchan/rflow to NULL if the allocation
>> actually fails.
>>
>> Fixes: 017794739702 ("dmaengine: ti: k3-udma: Initial support for K3 BCDMA")
>> Fixes: 25dcb5dd7b7c ("dmaengine: ti: New driver for K3 UDMA")
>> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
>
> Is this the same patch as the other with the similar subject?

Right, sorry for the duplicate patch (thought it didn't go out initially).

Regards
Kishon