Re: [next] [mips] spinlock.h:17:28: error: redefinition of 'queued_spin_unlock'

[Waiman Long]

On 2/10/21 12:30 AM, Naresh Kamboju wrote:
> While building Linux next tag 20210209 mips uImage.gz failed with below configs
>
>    - mips (cavium_octeon_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (malta_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (nlm_xlp_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=mips
> CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc'
> 'HOSTCC=sccache gcc' uImage.gz
> In file included from /include/linux/spinlock.h:90,
>                   from /include/linux/ipc.h:5,
>                   from /include/uapi/linux/sem.h:5,
>                   from /include/linux/sem.h:5,
>                   from /include/linux/compat.h:14,
>                   from /arch/mips/kernel/asm-offsets.c:12:
> /arch/mips/include/asm/spinlock.h:17:28: error: redefinition of
> 'queued_spin_unlock'
>     17 | #define queued_spin_unlock queued_spin_unlock
>        |                            ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
>
> build link,
> https://builds.tuxbuild.com/1oF9lkBAeWM2WvR11O2Yun8ERNT/
I have just posted a patch to reorder qspinlock.h and qrwlock.h include 
ordering. Hopefully that can fix the compilation problem though I don't 
have a mips building environment to verify that.

Cheers,
Longman