Re: [PATCH 2/8] lib: test_bitmap: add tests to trigger ERANGE case.

From: Andy Shevchenko
Date: Wed Feb 10 2021 - 11:30:13 EST


On Tue, Feb 09, 2021 at 05:59:01PM -0500, Paul Gortmaker wrote:
> Add tests that specify a valid range, but one that is outside the
> width of the bitmap for which it is to be applied to. These should
> trigger an -ERANGE response from the code.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Cc: Yury Norov <yury.norov@xxxxxxxxx>
> Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> lib/test_bitmap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 589f2a34ceba..172ffbfa83c4 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -338,6 +338,8 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> {-EINVAL, "-1", NULL, 8, 0},
> {-EINVAL, "-0", NULL, 8, 0},
> {-EINVAL, "10-1", NULL, 8, 0},
> + {-ERANGE, "8-8", NULL, 8, 0},
> + {-ERANGE, "0-31", NULL, 8, 0},
> {-EINVAL, "0-31:", NULL, 32, 0},
> {-EINVAL, "0-31:0", NULL, 32, 0},
> {-EINVAL, "0-31:0/", NULL, 32, 0},
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko