Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

[Hariprasad Kelam]

Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Tuesday, February 9, 2021 11:56 PM
> To: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; willemdebruijn.kernel@xxxxxxxxx;
> andrew@xxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Linu
> Cherian <lcherian@xxxxxxxxxxx>; Geethasowjanya Akula
> <gakula@xxxxxxxxxxx>; Jerin Jacob Kollanukkaran <jerinj@xxxxxxxxxxx>;
> Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>
> Subject: [EXT] Re: [Patch v4 net-next 0/7] ethtool support for fec and link
> configuration
> 
> On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:
> > v4:
> > 	- Corrected indentation issues
> > 	- Use FEC_OFF if user requests for FEC_AUTO mode
> > 	- Do not clear fec stats in case of user changes
> > 	  fec mode
> > 	- dont hide fec stats depending on interface mode
> > 	  selection
> 
> What about making autoneg modes symmetric between set and get?

Get supports multi modes such that user can select one of the modes to advertise.
For time being set only supports single mode. Do let me know if you want me to
Add this in commit description.

Thanks,
Hariprasad k