Re: [PATCH 0/5] KVM: x86/xen: Selftest fixes and a cleanup

From: Paolo Bonzini
Date: Wed Feb 10 2021 - 13:48:20 EST


On 10/02/21 19:26, Sean Christopherson wrote:
Fix a '40' vs '0x40' bug in the new Xen shinfo selftest, and clean up some
other oddities that made root causing the problem far more painful than it
needed to be.

Note, Paolo already queued a patch from Vitaly that adds the tests to
.gitignore[*], i.e. patch 01 can likely be dropped. I included it here
for completeness.

[*] https://lkml.kernel.org/r/20210129161821.74635-1-vkuznets@xxxxxxxxxx

Sean Christopherson (5):
KVM: selftests: Ignore recently added Xen tests' build output
KVM: selftests: Fix size of memslots created by Xen tests
KVM: selftests: Fix hex vs. decimal snafu in Xen test
KVM: sefltests: Don't bother mapping GVA for Xen shinfo test
KVM: x86/xen: Explicitly pad struct compat_vcpu_info to 64 bytes

arch/x86/kvm/xen.h | 11 ++++++-----
tools/testing/selftests/kvm/.gitignore | 2 ++
tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c | 12 +++++-------
tools/testing/selftests/kvm/x86_64/xen_vmcall_test.c | 3 +--
4 files changed, 14 insertions(+), 14 deletions(-)


Stupid question: how did you notice that? In other words what broke for you and not for me?

Paolo