Re: linux-next: build failure after merge of the driver-core tree

[Rob Herring]

On Wed, Feb 10, 2021 at 2:44 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> On Wed, Feb 10, 2021 at 12:15 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> >
> > On Wed, Feb 10, 2021 at 1:17 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Feb 10, 2021 at 11:06 AM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> > > >
> > > > On Wed, Feb 10, 2021 at 10:18 AM Greg KH <greg@xxxxxxxxx> wrote:
> > > > >
> > > > > On Wed, Feb 10, 2021 at 09:47:20PM +1100, Stephen Rothwell wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > After merging the driver-core tree, today's linux-next build (sparc64
> > > > > > defconfig) failed like this:
> > > > > >
> > > > > > drivers/of/property.o: In function `parse_interrupts':
> > > > > > property.c:(.text+0x14e0): undefined reference to `of_irq_parse_one'
> > > > > >
> > > > > > Caused by commit
> > > > > >
> > > > > >   f265f06af194 ("of: property: Fix fw_devlink handling of interrupts/interrupts-extended")
> > > > > >
> > > > > > CONFIG_OF_IRQ depends on !SPARC so of_irq_parse_one() needs a stub.
> >
> > It's always Sparc!
> >
> > > > > > I have added the following patch for today.
> > > > > >
> > > > > > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > > > > > Date: Wed, 10 Feb 2021 21:27:56 +1100
> > > > > > Subject: [PATCH] of: irq: make a stub for of_irq_parse_one()
> > > > > >
> > > > > > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > > > > > ---
> > > > > >  include/linux/of_irq.h | 9 +++++++--
> > > > > >  1 file changed, 7 insertions(+), 2 deletions(-)
> > > >
> > > > Thanks Stephen!
> > >
> > > Actually the stub needs to return an error. 0 indicates it found the interrupt.
> >
> > I have a slight preference if you could add an 'if
> > (!IS_ENABLED(CONFIG_OF_IRQ))' at the caller instead.
> >
> > If you grep of_irq_parse_one, you'll see there's only a few users
> > which means it's on my hit list to make it private. Stub functions
> > give the impression 'use everywhere'.
>
> I already sent out a fix :(

Okay, it's fine. I misread Greg's mail.

> Will that check optimize out the code and not cause build errors? If
> so, I can send out a patch later.

Yes, it will not trigger link errors. You could still get compile
errors if say a struct member is ifdef'ed out.

Rob