Re: [PATCH v5 02/14] dmaengine: idxd: add IMS detection in base driver

[Jason Gunthorpe]

On Fri, Feb 05, 2021 at 01:53:05PM -0700, Dave Jiang wrote:

> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index 21c1e23cdf23..ab5c76e1226b 100644
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -1444,6 +1444,14 @@ static ssize_t numa_node_show(struct device *dev,
>  }
>  static DEVICE_ATTR_RO(numa_node);
>  
> +static ssize_t ims_size_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct idxd_device *idxd = container_of(dev, struct idxd_device, conf_dev);
> +
> +	return sprintf(buf, "%u\n", idxd->ims_size);
> +}

use sysfs_emit for all new sysfs functions please

Jason