Re: [PATCH] ath9k: fix data bus crash when setting nf_override via debugfs

[Kalle Valo]

Linus Lüssing <linus.luessing@xxxxxxxxx> wrote:

> When trying to set the noise floor via debugfs, a "data bus error"
> crash like the following can happen:
> 
> [   88.433133] Data bus error, epc == 80221c28, ra == 83314e60
> [   88.438895] Oops[#1]:
> [   88.441246] CPU: 0 PID: 7263 Comm: sh Not tainted 4.14.195 #0
> [   88.447174] task: 838a1c20 task.stack: 82d5e000
> [   88.451847] $ 0   : 00000000 00000030 deadc0de 83141de4
> [   88.457248] $ 4   : b810a2c4 0000a2c4 83230fd4 00000000
> [   88.462652] $ 8   : 0000000a 00000000 00000001 00000000
> [   88.468055] $12   : 7f8ef318 00000000 00000000 77f802a0
> [   88.473457] $16   : 83230080 00000002 0000001b 83230080
> [   88.478861] $20   : 83a1c3f8 00841000 77f7adb0 ffffff92
> [   88.484263] $24   : 00000fa4 77edd860
> [   88.489665] $28   : 82d5e000 82d5fda8 00000000 83314e60
> [   88.495070] Hi    : 00000000
> [   88.498044] Lo    : 00000000
> [   88.501040] epc   : 80221c28 ioread32+0x8/0x10
> [   88.505671] ra    : 83314e60 ath9k_hw_loadnf+0x88/0x520 [ath9k_hw]
> [   88.512049] Status: 1000fc03 KERNEL EXL IE
> [   88.516369] Cause : 5080801c (ExcCode 07)
> [   88.520508] PrId  : 00019374 (MIPS 24Kc)
> [   88.524556] Modules linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp cdc_mbim batman_adv ath9k_hw ath sr9700 smsc95xx sierra_net rndis_host qmi_wwan pppox ppp_generic pl2303 nf_conntrack_ipv6 mcs7830 mac80211 kalmia iptable_nat ipt_REJECT ipt_MASQUERADE huawei_cdc_ncm ftdi_sio dm9601 cfg80211 cdc_subset cdc_ncm cdc_ether cdc_eem ax88179_178a asix xt_time xt_tcpudp xt_tcpmss xt_statistic xt_state xt_nat xt_multiport xt_mark xt_mac xt_limit xt_length xt_hl xt_ecn xt_dscp xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT xt_NETMAP xt_LOG xt_HL xt_FLOWOFFLOAD xt_DSCP xt_CLASSIFY usbserial usbnet usbhid slhc rtl8150 r8152 pegasus nf_reject_ipv4 nf_nat_redirect nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat nf_log_ipv4 nf_flow_table_hw nf_flow_table nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack
> [   88.597894]  libcrc32c kaweth iptable_mangle iptable_filter ipt_ECN ipheth ip_tables hso hid_generic crc_ccitt compat cdc_wdm cdc_acm br_netfilter hid evdev input_core nf_log_ipv6 nf_log_common ip6table_mangle ip6table_filter ip6_tables ip6t_REJECT x_tables nf_reject_ipv6 l2tp_netlink l2tp_core udp_tunnel ip6_udp_tunnel xfrm6_mode_tunnel xfrm6_mode_transport xfrm6_mode_beet ipcomp6 xfrm6_tunnel esp6 ah6 xfrm4_tunnel xfrm4_mode_tunnel xfrm4_mode_transport xfrm4_mode_beet ipcomp esp4 ah4 tunnel6 tunnel4 tun xfrm_user xfrm_ipcomp af_key xfrm_algo sha256_generic sha1_generic jitterentropy_rng drbg md5 hmac echainiv des_generic deflate zlib_inflate zlib_deflate cbc authenc crypto_acompress ehci_platform ehci_hcd gpio_button_hotplug usbcore nls_base usb_common crc16 mii aead crypto_null cryptomgr crc32c_generic
> [   88.671671]  crypto_hash
> [   88.674292] Process sh (pid: 7263, threadinfo=82d5e000, task=838a1c20, tls=77f81efc)
> [   88.682279] Stack : 00008060 00000008 00000200 00000000 00000000 00000000 00000000 00000002
> [   88.690916]         80500000 83230080 82d5fe22 00841000 77f7adb0 00000000 00000000 83156858
> [   88.699553]         00000000 8352fa00 83ad62b0 835302a8 00000000 300a00f8 00000003 82d5fe38
> [   88.708190]         82d5fef4 00000001 77f54dc4 77f80000 77f7adb0 c79fe901 00000000 00000000
> [   88.716828]         80510000 00000002 00841000 77f54dc4 77f80000 801ce4cc 0000000b 41824292
> [   88.725465]         ...
> [   88.727994] Call Trace:
> [   88.730532] [<80221c28>] ioread32+0x8/0x10
> [   88.734765] Code: 00000000  8c820000  0000000f <03e00008> 00000000  08088708  00000000  aca40000  03e00008
> [   88.744846]
> [   88.746464] ---[ end trace db226b2de1b69b9e ]---
> [   88.753477] Kernel panic - not syncing: Fatal exception
> [   88.759981] Rebooting in 3 seconds..
> 
> The "REG_READ(ah, AR_PHY_AGC_CONTROL)" in ath9k_hw_loadnf() does not
> like being called when the hardware is asleep, leading to this crash.
> 
> The easiest way to reproduce this is trying to set nf_override while
> the hardware is down:
> 
>   $ ip link set down dev wlan0
>   $ echo "-85" > /sys/kernel/debug/ieee80211/phy0/ath9k/nf_override
> 
> Fixing this crash by waking the hardware up before trying to set the
> noise floor. Similar to what other ath9k debugfs files do.
> 
> Tested on a Lima board from 8devices, which has a QCA 4531 chipset.
> 
> Fixes: b90189759a7f ("ath9k: add noise floor override option")
> Cc: Simon Wunderlich <sw@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Lüssing <ll@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

12c8f3d1cdd8 ath9k: fix data bus crash when setting nf_override via debugfs

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210209184352.4272-1-linus.luessing@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches