Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall

From: Jürgen Groß
Date: Thu Feb 11 2021 - 01:57:16 EST


On 10.02.21 18:06, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

After Commit 3499ba8198cad ("xen: Fix event channel callback via
INTX/GSI"), xenbus_probe() will be called too early on Arm. This will
recent to a guest hang during boot.

If there hang wasn't there, we would have ended up to call
xenbus_probe() twice (the second time is in xenbus_probe_initcall()).

We don't need to initialize xenbus_probe() early for Arm guest.
Therefore, the call in xen_guest_init() is now removed.

After this change, there is no more external caller for xenbus_probe().
So the function is turned to a static one. Interestingly there were two
prototypes for it.

Fixes: 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI")
Reported-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Pushed to xen/tip.git for-linus-5.11


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature