Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

[karthek]

Should i send them as patch series?

On Thu, Feb 11, 2021 at 1:27 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote:
> > @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B(
> >       if (bSetBandWidth)
> >               pHalData->bSetChnlBW = true;
> >
> > -     if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) {
> > -             /* DBG_871X("<= PHY_HandleSwChnlAndSetBW8812: bSwChnl %d, bSetChnlBW %d\n", pHalData->bSwChnl, pHalData->bSetChnlBW); */
> > +     if (!pHalData->bSetChnlBW && !pHalData->bSwChnl)
> >               return;
> > -     }
>
> In this case, the + line is correct.  Good job.
>
> >
> >
> >       if (pHalData->bSwChnl) {
> > @@ -929,9 +905,7 @@ void PHY_SetSwChnlBWMode8723B(
> >       u8 Offset80
> >  )
> >  {
> > -     /* DBG_871X("%s() ===>\n", __func__); */
> >
> >       PHY_HandleSwChnlAndSetBW8723B(Adapter, true, true, channel, Bandwidth, Offset40, Offset80, channel);
> >
> > -     /* DBG_871X("<==%s()\n", __func__); */
>
> Please delete the blank lines as well.
>
> regards,
> dan carpenter
>