RE: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

[Stefan Chulski]

> -----Original Message-----
> From: Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx>
> Sent: Thursday, February 11, 2021 2:50 PM
> To: Stefan Chulski <stefanc@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; thomas.petazzoni@xxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; Nadav Haklai <nadavh@xxxxxxxxxxx>; Yan
> Markman <ymarkman@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> kuba@xxxxxxxxxx; mw@xxxxxxxxxxxx; andrew@xxxxxxx;
> atenart@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> sebastian.hesselbarth@xxxxxxxxx; gregory.clement@xxxxxxxxxxx; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non
> occupied descriptor threshold
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, Feb 11, 2021 at 12:48:55PM +0200, stefanc@xxxxxxxxxxx wrote:
> > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > index 761f745..8b4073c 100644
> > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > @@ -1133,14 +1133,19 @@ static inline void
> > mvpp2_qvec_interrupt_disable(struct mvpp2_queue_vector *qvec)  static
> > void mvpp2_interrupts_mask(void *arg)  {
> >  	struct mvpp2_port *port = arg;
> > +	int cpu = smp_processor_id();
> > +	u32 thread;
> >
> >  	/* If the thread isn't used, don't do anything */
> > -	if (smp_processor_id() > port->priv->nthreads)
> > +	if (cpu > port->priv->nthreads)
> >  		return;
> 
> What happened to a patch fixing this? Did I miss it? Was it submitted
> independently to the net tree?

Some reviewers asked to remove this from the series. I would send it as separate patch to net.

Regards.