Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

[Daniel Borkmann]

On 2/10/21 3:50 PM, Willem de Bruijn wrote:
> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen <hxseverything@xxxxxxxxx> wrote:
> > From: huangxuesen <huangxuesen@xxxxxxxxxxxx>
> >
> > bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
> > encapsulation. But that is not appropriate when pushing Ethernet header.
> >
> > Add an option to further specify encap L2 type and set the inner_protocol
> > as ETH_P_TEB.
> >
> > Suggested-by: Willem de Bruijn <willemb@xxxxxxxxxx>
> > Signed-off-by: huangxuesen <huangxuesen@xxxxxxxxxxxx>
> > Signed-off-by: chengzhiyong <chengzhiyong@xxxxxxxxxxxx>
> > Signed-off-by: wangli <wangli09@xxxxxxxxxxxx>
>
> Thanks, this is exactly what I meant.
>
> Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx>
>
> One small point regarding Signed-off-by: It is customary to capitalize
> family and given names.

+1, huangxuesen, would be great if you could resubmit with capitalized names in
your SoB as well as From (both seem affected).

Thanks,
Daniel