Re: [PATCH v1 0/9] x86/platform: Remove SFI framework and users

From: Hans de Goede
Date: Thu Feb 11 2021 - 11:58:16 EST

Hi,

On 2/11/21 4:24 PM, Rafael J. Wysocki wrote:
> On Thu, Feb 11, 2021 at 2:50 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>
>> This is last part of Intel MID (SFI based) removal. We have no more users of it
>> in the kernel and since SFI has been marked Obsolete for a few years already,
>> Remove all the stuff altogether.
>>
>> Note, the more recent platforms (Intel Merrifield and Moorefield) still work as
>> long as they provide correct ACPI tables.
>>
>> The series requires two prerequisite branches to be pulled first, i.e.
>> - one form Rafael's PM tree (currently bleeding-edge)
>> - one form TIP tree (x86/platform), actually only one patch is needed from it
>>
>> Due to above it's convenient to proceed all of these via Rafael's PM tree,
>>
>> Note, atomisp change is tagged by Sakari on behalf of media tree maintainers.
>>
>> Andy Shevchenko (9):
>> media: atomisp: Remove unused header
>> cpufreq: sfi-cpufreq: Remove driver for deprecated firmware
>> sfi: Remove framework for deprecated firmware
>> x86/PCI: Get rid of custom x86 model comparison
>> x86/PCI: Describe @reg for type1_access_ok()
>> x86/platform/intel-mid: Get rid of intel_scu_ipc_legacy.h
>> x86/platform/intel-mid: Drop unused __intel_mid_cpu_chip and Co.
>> x86/platform/intel-mid: Remove unused header inclusion in intel-mid.h
>> x86/platform/intel-mid: Update Copyright year and drop file names
>>
>> Documentation/ABI/testing/sysfs-firmware-sfi | 15 -
>> Documentation/ABI/testing/sysfs-platform-kim | 2 +-
>> MAINTAINERS | 7 -
>> arch/x86/Kconfig | 7 +-
>> arch/x86/include/asm/intel-mid.h | 65 +--
>> arch/x86/include/asm/intel_scu_ipc.h | 2 -
>> arch/x86/include/asm/intel_scu_ipc_legacy.h | 74 ---
>> arch/x86/include/asm/platform_sst_audio.h | 2 -
>> arch/x86/kernel/apic/io_apic.c | 4 +-
>> arch/x86/kernel/setup.c | 2 -
>> arch/x86/pci/intel_mid_pci.c | 18 +-
>> arch/x86/pci/mmconfig-shared.c | 6 +-
>> arch/x86/platform/Makefile | 1 -
>> arch/x86/platform/intel-mid/Makefile | 5 -
>> .../platform/intel-mid/device_libs/Makefile | 23 -
>> .../intel-mid/device_libs/platform_bcm43xx.c | 101 ----
>> .../intel-mid/device_libs/platform_bma023.c | 16 -
>> .../intel-mid/device_libs/platform_bt.c | 101 ----
>> .../intel-mid/device_libs/platform_emc1403.c | 39 --
>> .../device_libs/platform_gpio_keys.c | 81 ---
>> .../intel-mid/device_libs/platform_lis331.c | 37 --
>> .../intel-mid/device_libs/platform_max7315.c | 77 ---
>> .../intel-mid/device_libs/platform_mpu3050.c | 32 --
>> .../device_libs/platform_mrfld_pinctrl.c | 39 --
>> .../device_libs/platform_mrfld_rtc.c | 44 --
>> .../intel-mid/device_libs/platform_mrfld_sd.c | 43 --
>> .../device_libs/platform_mrfld_spidev.c | 50 --
>> .../device_libs/platform_pcal9555a.c | 95 ----
>> .../intel-mid/device_libs/platform_tc35876x.c | 42 --
>> .../intel-mid/device_libs/platform_tca6416.c | 53 --
>> arch/x86/platform/intel-mid/intel-mid.c | 27 +-
>> arch/x86/platform/intel-mid/sfi.c | 419 --------------
>> arch/x86/platform/sfi/Makefile | 2 -
>> arch/x86/platform/sfi/sfi.c | 100 ----
>> drivers/Makefile | 2 +-
>> drivers/cpufreq/Kconfig.x86 | 10 -
>> drivers/cpufreq/Makefile | 1 -
>> drivers/cpufreq/sfi-cpufreq.c | 127 -----
>> drivers/platform/x86/intel_scu_pcidrv.c | 22 +-
>> drivers/sfi/Kconfig | 18 -
>> drivers/sfi/Makefile | 4 -
>> drivers/sfi/sfi_acpi.c | 214 -------
>> drivers/sfi/sfi_core.c | 522 ------------------
>> drivers/sfi/sfi_core.h | 81 ---
>> .../atomisp/include/linux/atomisp_platform.h | 1 -
>> include/linux/sfi.h | 210 -------
>> include/linux/sfi_acpi.h | 93 ----
>> init/main.c | 2 -
>> 48 files changed, 37 insertions(+), 2901 deletions(-)
>> delete mode 100644 Documentation/ABI/testing/sysfs-firmware-sfi
>> delete mode 100644 arch/x86/include/asm/intel_scu_ipc_legacy.h
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/Makefile
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_bcm43xx.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_bma023.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_bt.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_emc1403.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_gpio_keys.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_lis331.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_max7315.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_mpu3050.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_mrfld_pinctrl.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_mrfld_rtc.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_mrfld_sd.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_mrfld_spidev.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c
>> delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_tca6416.c
>> delete mode 100644 arch/x86/platform/intel-mid/sfi.c
>> delete mode 100644 arch/x86/platform/sfi/Makefile
>> delete mode 100644 arch/x86/platform/sfi/sfi.c
>> delete mode 100644 drivers/cpufreq/sfi-cpufreq.c
>> delete mode 100644 drivers/sfi/Kconfig
>> delete mode 100644 drivers/sfi/Makefile
>> delete mode 100644 drivers/sfi/sfi_acpi.c
>> delete mode 100644 drivers/sfi/sfi_core.c
>> delete mode 100644 drivers/sfi/sfi_core.h
>> delete mode 100644 include/linux/sfi.h
>> delete mode 100644 include/linux/sfi_acpi.h
>>
>> --
>
> All of this looks good to me, so I'm going to queue it up for 5.12
> unless there are objections against doing that.

That is fine by me (for the drivers/platform/x86 bits) :

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans