Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd

[Max Gurtovoy]

On 2/2/2021 7:10 PM, Jason Gunthorpe wrote:
> On Tue, Feb 02, 2021 at 05:06:59PM +0100, Cornelia Huck wrote:
>
> > On the other side, we have the zdev support, which both requires s390
> > and applies to any pci device on s390.
> Is there a reason why CONFIG_VFIO_PCI_ZDEV exists? Why not just always
> return the s390 specific data in VFIO_DEVICE_GET_INFO if running on
> s390?
>
> It would be like returning data from ACPI on other platforms.

Agree.

all agree that I remove it ?

we already have a check in the code:

if (ret && ret != -ENODEV) {
                                pci_warn(vdev->vpdev.pdev, "Failed to 
setup zPCI info capabilities\n");
                                return ret;
}

so in case its not zdev we should get -ENODEV and continue in the good flow.

> It really seems like part of vfio-pci-core
>
> Jason