Re: [PATCH] docs: reporting-issues.rst: explain how to decode stack traces

From: Randy Dunlap
Date: Thu Feb 11 2021 - 12:48:36 EST


Hi Thorsten,

Just a couple of small nits (or one that is repeated):

On 2/9/21 9:48 PM, Thorsten Leemhuis wrote:
> Replace placeholder text about decoding stack traces with a section that
> properly describes what a typical user should do these days. To make
> it works for them, add a paragraph in an earlier section to ensure
> people build their kernels with everything that's needed to decode stack
> traces later.
>
> Signed-off-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
> ---
> .../admin-guide/reporting-issues.rst | 77 +++++++++++++------
> 1 file changed, 55 insertions(+), 22 deletions(-)
>
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 07879d01fe68..b9c07d8e3141 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -154,8 +154,8 @@ After these preparations you'll now enter the main part:
> that hear about it for the first time. And if you learned something in this
> process, consider searching again for existing reports about the issue.
>
> - * If the failure includes a stack dump, like an Oops does, consider decoding
> - it to find the offending line of code.
> + * If your failure involves a 'panic', 'oops', or 'warning', consider decoding
> + the kernel log to find the line of code that trigger the error.

triggered

>
> * If your problem is a regression, try to narrow down when the issue was
> introduced as much as possible.
> @@ -869,6 +869,15 @@ pick up the configuration of your current kernel and then tries to adjust it
> somewhat for your system. That does not make the resulting kernel any better,
> but quicker to compile.
>
>
> Check 'taint' flag
> ------------------
> @@ -923,31 +932,55 @@ instead you can join.
> Decode failure messages
> -----------------------
>
> -.. note::
> + *If your failure involves a 'panic', 'oops', or 'warning', consider
> + decoding the kernel log to find the line of code that trigger the error.*

triggered


or it could be "code that triggers"... (just not "trigger").


--
~Randy