Re: [PATCH] staging: wlan-ng: Fix comments typos

From: Greg KH
Date: Thu Feb 11 2021 - 12:59:04 EST


On Thu, Feb 11, 2021 at 05:55:18PM +0100, Mairo P. Rufus wrote:
> > Hi,
> >
> > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> > a patch that has triggered this response. He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created. Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> >
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> >
> > - You did not specify a description of why the patch is needed, or
> > possibly, any description at all, in the email body. Please read the
> > section entitled "The canonical patch format" in the kernel file,
> > Documentation/SubmittingPatches for what is needed in order to
> > properly describe the change.
> >
> > - You did not write a descriptive Subject: for the patch, allowing Greg,
> > and everyone else, to know what this patch is all about. Please read
> > the section entitled "The canonical patch format" in the kernel file,
> > Documentation/SubmittingPatches for what a proper Subject: line should
> > look like.
> >
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> >
> > thanks,
> >
> > greg k-h's patch email bot
>
> After double checking, I still can't figure out what I did wrong. I'm
> sorry for abusing your time, but can you help me on this one?

You don't quote your changelog text here, so it's hard to determine what
needs to be done.

But your subject line could use a lot of work, don't you agree? Read
the above links for how to write a good one.

thanks,

greg k-h