Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs

From: Bjorn Andersson
Date: Thu Feb 11 2021 - 13:53:06 EST


On Wed 10 Feb 04:45 CST 2021, Vinod Koul wrote:

> Add the SM8350 audio, compute, modem and sensor remoteprocs to the PAS
> DT binding.
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> ---
> .../devicetree/bindings/remoteproc/qcom,adsp.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 54737024da20..41eaa2466aab 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -25,6 +25,10 @@ on the Qualcomm ADSP Hexagon core.
> "qcom,sm8250-adsp-pas"
> "qcom,sm8250-cdsp-pas"
> "qcom,sm8250-slpi-pas"
> + "qcom,sm8350-adsp-pas"
> + "qcom,sm8350-cdsp-pas"
> + "qcom,sm8350-slpi-pas"
> + "qcom,sm8350-mpss-pas"
>
> - interrupts-extended:
> Usage: required
> @@ -51,10 +55,14 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sm8250-adsp-pas:
> qcom,sm8250-cdsp-pas:
> qcom,sm8250-slpi-pas:
> + qcom,sm8350-adsp-pas:
> + qcom,sm8350-cdsp-pas:
> + qcom,sm8350-slpi-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack"
> qcom,qcs404-wcss-pas:
> qcom,sc7180-mpss-pas:
> qcom,sm8150-mpss-pas:
> + qcom,sm8350-mpss-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack",
> "shutdown-ack"
>
> @@ -113,14 +121,18 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sdm845-cdsp-pas:
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> + qcom,sm8250-cdsp-pas:

This should be sm8350, I fixed this up and applied the patch.

Thanks,
Bjorn

> qcom,sm8250-cdsp-pas:
> must be "cx", "load_state"
> qcom,sc7180-mpss-pas:
> qcom,sm8150-mpss-pas:
> + qcom,sm8350-mpss-pas:
> must be "cx", "load_state", "mss"
> qcom,sm8250-adsp-pas:
> + qcom,sm8350-adsp-pas:
> qcom,sm8150-slpi-pas:
> qcom,sm8250-slpi-pas:
> + qcom,sm8350-slpi-pas:
> must be "lcx", "lmx", "load_state"
>
> - memory-region:
> --
> 2.26.2
>