Re: [PATCH v2 1/3] x86/vmemmap: Drop handling of 4K unaligned vmemmap range

From: Oscar Salvador
Date: Thu Feb 11 2021 - 16:26:22 EST


On Wed, Feb 03, 2021 at 11:47:48AM +0100, Oscar Salvador wrote:
> remove_pte_table() is prepared to handle the case where either the
> start or the end of the range is not PAGE aligned.
> This cannot actually happen:
>
> __populate_section_memmap enforces the range to be PMD aligned,
> so as long as the size of the struct page remains multiple of 8,
> the vmemmap range will be aligned to PAGE_SIZE.
>
> Drop the dead code and place a VM_BUG_ON in vmemmap_{populate,free}
> to catch nasty cases.
>
> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
> Suggested-by: David Hildenbrand <david@xxxxxxxxxx>

Hi Andrew,

the cover letter got lost somehow, but is this patchset, [1] and [2]
on your radar?

[1] https://lore.kernel.org/linux-mm/20210204134325.7237-3-osalvador@xxxxxxx/
[2] https://lore.kernel.org/linux-mm/20210204134325.7237-4-osalvador@xxxxxxx/

thanks


--
Oscar Salvador
SUSE L3