Re: [PATCH v5 2/2] counter: add IRQ or GPIO based event counter

From: Linus Walleij
Date: Fri Feb 12 2021 - 04:27:58 EST


On Mon, Feb 8, 2021 at 2:53 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Add simple IRQ or GPIO base event counter. This device is used to measure
> rotation speed of some agricultural devices, so no high frequency on the
> counter pin is expected.
>
> The maximal measurement frequency depends on the CPU and system load. On
> the idle iMX6S I was able to measure up to 20kHz without count drops.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>

>From GPIO and interrupt point of view this driver looks good to me.
I don't know about the userspace interface etc.

Yours,
Linus Walleij