Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

[kernel test robot]

Hi Srinivasan,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master net-next/master net/master linus/master sparc-next/master v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivasan-Raju/wireless-Initial-driver-submission-for-pureLiFi-STA-devices/20210212-195451
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5d8fb5ce1f136940c10fd16bc96856d2f6ad2741
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Srinivasan-Raju/wireless-Initial-driver-submission-for-pureLiFi-STA-devices/20210212-195451
        git checkout 5d8fb5ce1f136940c10fd16bc96856d2f6ad2741
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10,
                    from drivers/net/wireless/purelifi/plfxlc/usb.c:6:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   drivers/net/wireless/purelifi/plfxlc/usb.c: At top level:
>> drivers/net/wireless/purelifi/plfxlc/usb.c:962:20: error: 'suspend' undeclared here (not in a function)
     962 |  .suspend        = suspend,
         |                    ^~~~~~~
>> drivers/net/wireless/purelifi/plfxlc/usb.c:963:20: error: 'resume' undeclared here (not in a function); did you mean 'resource'?
     963 |  .resume         = resume,
         |                    ^~~~~~
         |                    resource
   drivers/net/wireless/purelifi/plfxlc/usb.c:909:29: warning: 'get_purelifi_usb' defined but not used [-Wunused-function]
     909 | static struct purelifi_usb *get_purelifi_usb(struct usb_interface *intf)
         |                             ^~~~~~~~~~~~~~~~


vim +/suspend +962 drivers/net/wireless/purelifi/plfxlc/usb.c

   954	
   955	static struct usb_driver driver = {
   956		.name        = KBUILD_MODNAME,
   957		.id_table    = usb_ids,
   958		.probe        = probe,
   959		.disconnect    = disconnect,
   960		.pre_reset    = pre_reset,
   961		.post_reset    = post_reset,
 > 962		.suspend        = suspend,
 > 963		.resume         = resume,
   964		.disable_hub_initiated_lpm = 1,
   965	};
   966	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip