Re: [PATCH v1 5/7] net: ipa: Add support for IPA on MSM8998

From: Jakub Kicinski
Date: Fri Feb 12 2021 - 13:51:26 EST


On Thu, 11 Feb 2021 18:50:13 +0100 AngeloGioacchino Del Regno wrote:
> MSM8998 features IPA v3.1 (GSI v1.0): add the required configuration
> data for it.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>

This one does not build:

drivers/net/ipa/ipa_data-msm8998.c:382:3: error: ‘struct ipa_clock_data’ has no member named ‘interconnect’; did you mean ‘interconnect_data’?
382 | .interconnect = {
| ^~~~~~~~~~~~
| interconnect_data
drivers/net/ipa/ipa_data-msm8998.c:382:2: warning: braces around scalar initializer
382 | .interconnect = {
| ^
drivers/net/ipa/ipa_data-msm8998.c:382:2: note: (near initialization for ‘ipa_clock_data.interconnect_count’)
drivers/net/ipa/ipa_data-msm8998.c:383:4: error: ‘IPA_INTERCONNECT_MEMORY’ undeclared here (not in a function)
383 | [IPA_INTERCONNECT_MEMORY] = {
| ^~~~~~~~~~~~~~~~~~~~~~~


Each commit must build cleanly and not add any transient W=1 C=1
warnings.