RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

From: Min Li
Date: Fri Feb 12 2021 - 14:07:47 EST


>
> On Fri, Feb 12, 2021 at 03:44:52PM +0000, Min Li wrote:
> > > >
> > > > -set combomode
> > > > -get dpll's state
> > > > -get dpll's ffo
> > > >
> > > > This driver must work with Renesas MFD driver to access SMU
> > > > through I2C/SPI.
> > > >
> > > > Changes since v1:
> > > > -Provide more background for purpose of the change.
> > > > -Provide compat_ioctl support
> > > > -Fix ioctl cmd definition
> > >
> > > This "changes" list goes below the --- line.
> > >
> >
> > Sorry, is this a problem that you are requesting me to address? I am bit
> confused...
>
> Yes, please place that list of changes below the --- line in your patch.
> The documentation says to do this, right?
>
Hi Greg

Do you mean this "---" like below? How can I do that? Sorry I was never asked to do that from other reviewer.

Signed-off-by: Min Li <min.li.xe@xxxxxxxxxxx>
---
drivers/misc/Kconfig | 13 ++
drivers/misc/Makefile | 3 +
drivers/misc/rsmu_cdev.c | 449 ++++++++++++++++++++++++++++++++++++++++++++++
drivers/misc/rsmu_cdev.h | 75 ++++++++
drivers/misc/rsmu_cm.c | 214 ++++++++++++++++++++++
drivers/misc/rsmu_sabre.c | 153 ++++++++++++++++
include/uapi/linux/rsmu.h | 61 +++++++
7 files changed, 968 insertions(+)
create mode 100644 drivers/misc/rsmu_cdev.c
create mode 100644 drivers/misc/rsmu_cdev.h
create mode 100644 drivers/misc/rsmu_cm.c
create mode 100644 drivers/misc/rsmu_sabre.c
create mode 100644 include/uapi/linux/rsmu.h