Re: [PATCH mm] kasan: export HW_TAGS symbols for KUnit tests
From: Andrey Konovalov
Date: Fri Feb 12 2021 - 16:11:39 EST
On Fri, Feb 12, 2021 at 10:08 PM Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, 12 Feb 2021 22:01:38 +0100 Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote:
>
> > On Fri, Feb 12, 2021 at 9:54 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Fri, 12 Feb 2021 21:21:39 +0100 Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote:
> > >
> > > > > > The wrappers aren't defined when tests aren't enabled to avoid misuse.
> > > > > > The mte_() functions aren't exported directly to avoid having low-level
> > > > > > KASAN ifdefs in the arch code.
> > > > > >
> > > > >
> > > > > Please confirm that this is applicable to current Linus mainline?
> > > >
> > > > It's not applicable. KUnit tests for HW_TAGS aren't supported there,
> > > > the patches for that are in mm only. So no need to put it into 5.11.
> > >
> > > So... which -mm patch does this patch fix?
> >
> > "kasan, arm64: allow using KUnit tests with HW_TAGS mode".
> >
> > There will be some minor adjacent-line-changed conflicts if you decide
> > to squash it.
> >
> > Alternatively, this can go as a separate patch after the tests series
> > (after "kasan: don't run tests when KASAN is not enabled").
>
> Thanks - it wasn't obvious.
>
> I staged it as a fix against "kasan, arm64: allow using KUnit tests
> with HW_TAGS mode". To make the series as nice as we can, and to avoid
> bisection holes.
Sounds good, thank you!