Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

From: Vladimir Oltean
Date: Sat Feb 13 2021 - 21:20:49 EST


Hi Michael,

On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote:
> at803x_aneg_done() checks if auto-negotiation is completed on the SGMII
> side. This doesn't take the mdio bus lock and the page switching is
> open-coded. Now that we have proper page support, just use
> phy_read_paged(). Also use phydev->interface to check if we have an
> SGMII link instead of reading the mode register and be a bit more
> precise on the warning message.
>
> Signed-off-by: Michael Walle <michael@xxxxxxxx>
> ---

How did you test this patch?