Re: [PATCH v8 19/22] counter: Implement extension*_name sysfs attributes

From: Jonathan Cameron
Date: Sun Feb 14 2021 - 13:10:09 EST


On Fri, 12 Feb 2021 21:13:43 +0900
William Breathitt Gray <vilhelm.gray@xxxxxxxxx> wrote:

> The Generic Counter chrdev interface expects users to supply extension
> IDs in order to select extensions for requests. In order for users to
> know what extension ID belongs to which extension this information must
> be exposed. The extension*_name attribute provides a way for users to
> discover what extension ID belongs to which extension by reading the
> respective extension name for an extension ID.
>
> Cc: David Lechner <david@xxxxxxxxxxxxxx>
> Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> ---
> Documentation/ABI/testing/sysfs-bus-counter | 9 ++++
> drivers/counter/counter-sysfs.c | 51 +++++++++++++++++----
> 2 files changed, 50 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter
> index 6353f0a2f8f8..847e96f19d19 100644
> --- a/Documentation/ABI/testing/sysfs-bus-counter
> +++ b/Documentation/ABI/testing/sysfs-bus-counter
> @@ -100,6 +100,15 @@ Description:
> Read-only attribute that indicates whether excessive noise is
> present at the channel Y counter inputs.
>
> +What: /sys/bus/counter/devices/counterX/countY/extensionZ_name
> +What: /sys/bus/counter/devices/counterX/extensionZ_name
> +What: /sys/bus/counter/devices/counterX/signalY/extensionZ_name
> +KernelVersion: 5.13
> +Contact: linux-iio@xxxxxxxxxxxxxxx
> +Description:
> + Read-only attribute that indicates the component name of
> + Extension Z.

Good to say what form this takes.

> +