Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties
From: Krzysztof Kozlowski
Date: Mon Feb 15 2021 - 04:30:24 EST
On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
> > Add common properties appearing in DTSes (assigned-clocks and similar)
> > to fix dtbs_check warnings like:
> >
> > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
> > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'
>
> Does it mean that assigned-clocks related properties have to be added to
> almost all bindings?
To my understanding: yes, and we already added it to multiple schemas.
> IMHO this is an over-engineering and this has to be
> handled somewhere else...
Would have to be made a part of the core schema (just like pinctrl nodes
etc).
Best regards,
Krzysztof