Re: linux-next: build warning after merge of the pm tree

From: Andy Shevchenko
Date: Mon Feb 15 2021 - 05:27:11 EST


+Cc: Patrik (JFYI).

On Mon, Feb 15, 2021 at 12:23 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > In file included from drivers/gpu/drm/gma500/mdfld_output.c:28:
> > arch/x86/include/asm/intel_scu_ipc.h:23:12: warning: 'struct module' declared inside parameter list will not be visible outside of this definition or declaration
> > 23 | struct module *owner);
> > | ^~~~~~
> > arch/x86/include/asm/intel_scu_ipc.h:33:17: warning: 'struct module' declared inside parameter list will not be visible outside of this definition or declaration
> > 33 | struct module *owner);
> > | ^~~~~~
> >
> > Introduced by commit
> >
> > bfc838f8598e ("drm/gma500: Convert to use new SCU IPC API")
> >
> > OK, these will go away when the drm-misc tree removes this file in commit
> >
> > e1da811218d2 ("drm/gma500: Remove Medfield support")
> >
> > So, if you don't want to see these warnings in Linus' build testing,
> > you need to make sure that the drm-misc tree is merged before the pm
> > tree (or the drivers-x86 tree). Or you need to include module.h in
> > mdfld_output.c before intel_scu_ipc.h (or in intel_scu_ipc.h itself).
>
> Thanks for the report.
> I guess the DRM tree should carry this burden, or they can merge the
> immutable tag themselves.
>
> --
> With Best Regards,
> Andy Shevchenko



--
With Best Regards,
Andy Shevchenko