Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

From: Dan Carpenter
Date: Mon Feb 15 2021 - 05:53:22 EST


On Thu, Feb 11, 2021 at 03:40:39PM +0530, Viresh Kumar wrote:
> On 11-02-21, 11:00, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
> > > This patch add fixes an checkpatch error for "Macros with multiple statements
> > > should be enclosed in a do - while loop"
> > >
> > > Signed-off-by: Hemansh Agnihotri <hemanshagnihotri27@xxxxxxxxx>
> >
> > Any reason you didn't test-build your patch before sending it out?
> >
> > That's a bit rude to reviewers :(
>
> I also wonder how two people stumbled upon the exact same thing at the
> same time. Copy/paste ?
>

Those things are pretty common where people try to fix the first
checkpatch warning they find. There was one time some years back when 5
people sent the same patch.

regards,
dan carpenter