Re: [PATCH] vfio/type1: Use follow_pte()

From: Cornelia Huck
Date: Mon Feb 15 2021 - 06:08:05 EST


On Fri, 12 Feb 2021 12:01:50 -0700
Alex Williamson <alex.williamson@xxxxxxxxxx> wrote:

> follow_pfn() doesn't make sure that we're using the correct page
> protections, get the pte with follow_pte() so that we can test
> protections and get the pfn from the pte.
>
> Fixes: 5cbf3264bc71 ("vfio/type1: Fix VA->PA translation for PFNMAP VMAs in vaddr_get_pfn()")
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> ---
> drivers/vfio/vfio_iommu_type1.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>

With the function signature adapted:

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>