Re: [PATCH 1/3] dmaengine: hsu: Add missing call to 'pci_free_irq_vectors()' in probe and remove functions

From: Andy Shevchenko
Date: Mon Feb 15 2021 - 08:28:21 EST


On Sun, Feb 14, 2021 at 3:22 PM Dejin Zheng <zhengdejin5@xxxxxxxxx> wrote:
>
> Call to 'pci_free_irq_vectors()' are missing both in the error handling
> path of the probe function, and in the remove function.
> Add them.

> Fixes: e9bb8a9df316a2 ("dmaengine: hsu: pci: switch to new API for IRQ allocation")

Same as per others. This does not fix anything, because there is no issue.
If you want to have it better, introduce a pcim_alloc_irq_vectors() to
show that it's managed.


--
With Best Regards,
Andy Shevchenko