Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

From: Andy Shevchenko
Date: Mon Feb 15 2021 - 09:40:52 EST


+Cc: Sakari and printk people

On Mon, Feb 15, 2021 at 4:28 PM Christian König
<christian.koenig@xxxxxxx> wrote:
> Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > We have already few similar implementation and a lot of code that can benefit
> > of the yesno() helper. Consolidate yesno() helpers under string.h hood.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Looks like a good idea to me, feel free to add an Acked-by: Christian
> König <christian.koenig@xxxxxxx> to the series.

Thanks.

> But looking at the use cases for this, wouldn't it make more sense to
> teach kprintf some new format modifier for this?

As a next step? IIRC Sakari has at some point the series converted
yesno and Co. to something which I don't remember the details of.

Guys, what do you think?

--
With Best Regards,
Andy Shevchenko